Fix clang tidy ci #2375
Merged
Fix clang tidy ci #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
fix-clang-tidy-ci
branch
23 times, most recently
from
b8443c3 to
9b40ed0
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
crypto/bio/bio.c
Outdated
| @@ -443,7 +443,7 @@ int BIO_flush(BIO *bio) { | |||
| } | |||
|
|
|||
| long BIO_ctrl(BIO *bio, int cmd, long larg, void *parg) { | |||
| if (bio == NULL) { | |||
| if (bio != NULL) { | |||
| return 0; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
warning: Access to field 'method' results in a dereference of a null pointer (loaded from variable 'bio') [clang-analyzer-core.NullDereference]
if (bio->method == NULL || bio->method->ctrl == NULL) {
^Additional context
crypto/bio/bio.c:598: Passing value via 1st parameter 'bio'
return (int)BIO_ctrl(bio, BIO_CTRL_SET_CLOSE, close_flag, NULL);
^crypto/bio/bio.c:598: Calling 'BIO_ctrl'
return (int)BIO_ctrl(bio, BIO_CTRL_SET_CLOSE, close_flag, NULL);
^crypto/bio/bio.c:445: Assuming 'bio' is equal to NULL
if (bio != NULL) {
^crypto/bio/bio.c:445: Taking false branch
if (bio != NULL) {
^crypto/bio/bio.c:449: Access to field 'method' results in a dereference of a null pointer (loaded from variable 'bio')
if (bio->method == NULL || bio->method->ctrl == NULL) {
^
justsmth
force-pushed
the
fix-clang-tidy-ci
branch
3 times, most recently
from
a1262f4 to
4109d21
Compare
andrewhop
reviewed
Apr 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2375 +/- ##
==========================================
- Coverage 78.81% 78.80% -0.02%
==========================================
Files 621 621
Lines 108417 108417
Branches 15399 15399
==========================================
- Hits 85447 85435 -12
- Misses 22299 22312 +13
+ Partials 671 670 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
fix-clang-tidy-ci
branch
4 times, most recently
from
40589ff to
5f5ed93
Compare
justsmth
commented
Apr 29, 2025
| @@ -11,6 +11,5 @@ Checks: ' | |||
| modernize-*, | |||
| performance-*, | |||
| portability-*, | |||
| readability-* | |||
There was a problem hiding this comment.
The "readability-*" lints are very noisy in our code base.
justsmth
force-pushed
the
fix-clang-tidy-ci
branch
from
5f5ed93 to
bab60d3
Compare
andrewhop
approved these changes
May 9, 2025
smittals2
approved these changes
May 9, 2025
skmcgrail
added a commit
that referenced
this pull request
May 23, 2025
## What's Changed * Fix prefix build when path has spaces by @justsmth in #2400 * Prepare v1.51.2 by @justsmth in #2401 * Set OPENSSL_NO_EXTERNAL_PSK_TLS13 to indicate lack of TLS 1.3 PSK by @WillChilds-Klein in #2399 * BIO datagram functions by @justsmth in #2321 * Reject NewSessionTicket messages with empty tickets in TLS 1.3 by @justsmth in #2367 * Ensure that AVX512 is not used on macOS by @justsmth in #2363 * Fix socket test issues by @torben-hansen in #2404 * Remove python CI patch for main by @WillChilds-Klein in #2407 * Remove xmlsec patch by @smittals2 in #2405 * Fix clang tidy ci by @justsmth in #2375 * Mark fallible container operations as `nodiscard` by @justsmth in #2366 * Remove extra va_end in err_add_error_vdata by @justsmth in #2364 * Check for QUIC in SSL_process_quic_post_handshake by @justsmth in #2365 * Add missing symbols for Unbound by @nhatnghiho in #2352 * Update mlkem-native by @hanno-becker in #2406 * CI for iOS by @justsmth in #2389 * Squelch clang-tidy by @justsmth in #2414 * Clang-tidy is still noisy by @justsmth in #2417 * Add back two rules for clang-tidy by @smittals2 in #2418 * Implement BIO_dump by @kingstjo in #2331 * Make ASN1_get_object a direct call by @samuel40791765 in #2332 * Add Python 3.9 CI patch by @WillChilds-Klein in #2415 * Rework memory BIOs and implement BIO_seek by @nhatnghiho in #2380 * ML-DSA: ASN.1 Module - add parsing of BOTH private key format by @jakemas in #2416 * Detection of unused results by @justsmth in #2411 * Fix gtest_util.sh failure detection by @justsmth in #2423 * Remove unused docs/configs by @torben-hansen in #2427 * ML-DSA: Add ML-DSA keyGen to break-kat.go by @jakemas in #2422 * Fix CI for mingw by @justsmth in #2428 * Bump AWSLC_API_VERSION for X509_STORE_CTX_set_verify_crit_oids by @samuel40791765 in #2426 * Revert "Rework memory BIOs and implement BIO_seek (#2380)" by @samuel40791765 in #2432 * Resolve SSL_PRIVATE_METHOD and certificate slots functionality by @skmcgrail in #2429 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses P229174291
Description of changes:
Fixes usage of clang-tidy-review:
compile_commands.jsonMade changes to clang-tidy-review to preserve comments that are very close to lines in the diff
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.